Skip to content

Remove ExpressionBuilder::andX()/orX() #3865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2020
Merged

Remove ExpressionBuilder::andX()/orX() #3865

merged 1 commit into from
Jan 30, 2020

Conversation

BenMorel
Copy link
Contributor

Continuing the work started in #3851, this time on master.

@morozov morozov added this to the 4.0.0 milestone Jan 30, 2020
@morozov morozov merged commit ed4ac2a into doctrine:master Jan 30, 2020
@morozov
Copy link
Member

morozov commented Jan 30, 2020

Thanks, @BenMorel!

@morozov morozov self-assigned this Jan 30, 2020
@BenMorel
Copy link
Contributor Author

Thanks! Could you please let me know when you merge it to master, so that I can continue the work there and to fix #3845?

@morozov
Copy link
Member

morozov commented Jan 30, 2020

@BenMorel you mean merge this PR into master? It's already merged.

@BenMorel
Copy link
Contributor Author

Sorry, I left the comment on the wrong PR. I meant to write it on #3864.

@morozov
Copy link
Member

morozov commented Jan 30, 2020 •
edited
Loading

Just filed #3866, #3867.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@morozov morozov morozov approved these changes

Assignees

@morozov morozov

Labels

BC Break Improvement QueryBuilder

Projects

None yet

Milestone

4.0.0-beta1

Development

Successfully merging this pull request may close these issues.

2 participants

@BenMorel @morozov