Skip to content

Conversation

morozov
Copy link
Member

@morozov morozov commented Nov 7, 2019

Right now, building on pdo_oci is disabled due to failures (#3712 (comment)).

As per the support response, continuousphp switched to building their containers based on the official images from PHP.

Q A
Type improvement
BC Break no

As per the support response, continuousphp switched to building their containers based on the official images from PHP.
@morozov morozov changed the base branch from master to 2.10 November 25, 2019 15:39
@morozov morozov force-pushed the continuousphp-pdo-oci branch from f9b76eb to 8388ebc Compare November 25, 2019 15:40
@morozov morozov added this to the 2.10.1 milestone Nov 25, 2019
@morozov morozov requested review from lcobucci and Ocramius November 25, 2019 15:46
@morozov morozov removed the WIP label Nov 25, 2019
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius self-assigned this Nov 25, 2019
Copy link
Member

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@morozov morozov merged commit 0a5790b into doctrine:2.10 Nov 25, 2019
@morozov morozov deleted the continuousphp-pdo-oci branch November 25, 2019 16:55
@morozov
Copy link
Member Author

morozov commented Nov 25, 2019

Now we need to get this and other changes from 2.10 into master.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants