Enforced parameter and return value types in Platform classes #3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
commented
May 28, 2019
| @@ -83,7 +83,7 @@ public function getDatabase(Connection $conn) : ?string | |||
| { | |||
| $params = $conn->getParams(); | |||
|
|
|||
| return $params['path'] ?? null; | |||
| return $params['path'] ?? ''; | |||
There was a problem hiding this comment.
The returned NULL implies that there's no database currently selected, however, SQLite doesn't support databases and one is always selected implicitly. Some of the platform methods do not allow NULL for $database which previously was only documented but not enforced.
The method documentation will be updated in a subsequent pull request.
morozov
commented
May 28, 2019
| */ | ||
| public function testReturnsDatabaseNameWithoutDatabaseNameParameter() | ||
| { | ||
| $this->markTestSkipped('SQLite does not support the concept of a database.'); |
There was a problem hiding this comment.
Previously, this test would only pass with an in-memory SQLite database for which Driver::getDatabase() would return NULL. The test is invalid with SQLite by design.
morozov
commented
May 28, 2019
| @@ -884,10 +875,6 @@ public function testGeneratesSequenceSqlCommands() | |||
| 'SELECT myseq.NEXTVAL', | |||
| $this->platform->getSequenceNextValSQL('myseq') | |||
| ); | |||
| self::assertEquals( | |||
| 'SELECT sequence_name, increment_by, start_with, min_value FROM SYS.SYSSEQUENCE', | |||
| $this->platform->getListSequencesSQL(null) | |||
There was a problem hiding this comment.
This is no longer valid.
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Enforced parameter and return value types in Platform classes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Enforced parameter and return value types in Platform classes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Enforced parameter and return value types in Platform classes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Enforced parameter and return value types in Platform classes
morozov
added a commit
that referenced
this pull request
Jun 13, 2019
Enforced parameter and return value types in Platform classes
morozov
added a commit
that referenced
this pull request
Jun 27, 2019
Enforced parameter and return value types in Platform classes
morozov
added a commit
that referenced
this pull request
Jun 27, 2019
Enforced parameter and return value types in Platform classes
morozov
added a commit
that referenced
this pull request
Jun 27, 2019
Enforced parameter and return value types in Platform classes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Aug 26, 2019
Enforced parameter and return value types in Platform classes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Aug 27, 2019
Enforced parameter and return value types in Platform classes
morozov
added a commit
that referenced
this pull request
Nov 2, 2019
Enforced parameter and return value types in Platform classes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
$databaseargument inAbstractPlatformmethods is not final. It just reflects the current type. The type can be restricted to a non-nullablestringin a subsequent PR.