Reworked AbstractSchemaManager::extractDoctrineTypeFromComment(), removed ::removeDoctrineTypeFromComment()

[morozov]

Q	A
Type	improvement
BC Break	yes

Currently, AbstractSchemaManager::extractDoctrineTypeFromComment() and ::removeDoctrineTypeFromComment() have to be called separately, one after the other, and duplicate implementation, however they are parts of a single whole: extracting a Doctrine type from the column comment.

The fact that the former requires passing $currentType makes it hard to use when the type is not yet known (see SqliteSchemaManager) and hard to guess if the type was actually extracted (it takes passing a knowingly wrong type and compare it with the result).

The proposed implementation makes the usage more straightforward. I would like to keep testExtractDoctrineTypeFromComment in place but I don't think the method is worth extraction into a separate class. Therefore, reflection is used in the test.

It's still unclear to me whether column comments should be nullable or not in general (I'd love them to not be), but making a decision requires a larger effort which will be made later. It's actually not being currently changed.

[morozov]

@Ocramius, @Majkl578 while I understand your arguments, I don't find them sufficient for blocking the change or changing the proposed API. Let's move on, please.

[Majkl578]

Hmm, I'm not a native speaker so my perception of this may be wrong. I don't really have anything else to say except the naming.