Create schemas and permissions in more situations #2838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On trusty, this is needed for all mysql/mariadb builds. Fixes doctrine#2837
Majkl578
approved these changes
Sep 2, 2017
|
Restarting the build because I've had a new issue locally even with that change |
|
Ok still green :) |
|
I know, but your PR is big and still red, so not mergeable right now. I just noticed that Travis is not required for the build to pass, so this is not as critical as I think. However this situation is not great, because people might assume they didn't break the build when they actually did. Right now they can't know for sure unless they check the output of the logs on each commit. |
|
Handled in #2849, sorry for extra work. |
|
Not a big deal :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On trusty, this is needed for all mysql/mariadb builds.
Fixes #2837