Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLServer: Ascii_string type definition is always fixed length #6245

Open
kicken opened this issue Dec 20, 2023 · 0 comments
Open

SQLServer: Ascii_string type definition is always fixed length #6245

kicken opened this issue Dec 20, 2023 · 0 comments
Labels
Bug SQL Server

Comments

@kicken
Copy link

kicken commented Dec 20, 2023 •
edited by morozov
Loading

dbal/src/Platforms/SQLServerPlatform.php

Line 1292 in 6a793fb

if (! isset($column['fixed'])) {

The SQL Server platform always generates a fixed length column definition. The code checks if the fixed option is set, rather than if it's true/false. The option is always set, so this test is always false.
@Yovach Yovach mentioned this issue May 6, 2024
Merged
derrabus pushed a commit that referenced this issue Aug 14, 2024
@Yovach
Fix condition on Ascii String for SQL Server (#6389)
1f8b3fb 
<!-- Fill in the relevant information below to help triage your pull
request. -->

|      Q       |   A
|------------- | -----------
| Type         | bug
| Fixed issues | #6245

#### Summary

This MR fixes a condition on SQL Server where `fixed` is always defined
as `true` or `false` so `return sprintf('VARCHAR(%d)', $length ?? 255);`
is always ignored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug SQL Server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@derrabus @kicken