Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A call to the non-deprecated AbstractPlatform::getAdvancedForeignKeyOptionsSQL() triggers a deprecation #4886

Closed
simonberger opened this issue Oct 16, 2021 · 4 comments · Fixed by #4890
Closed

A call to the non-deprecated AbstractPlatform::getAdvancedForeignKeyOptionsSQL() triggers a deprecation #4886

simonberger opened this issue Oct 16, 2021 · 4 comments · Fixed by #4890
Labels
Bug Deprecation Platforms
Milestone
2.13.5

Comments

@simonberger
Copy link
Contributor

Dbal 2.13.4 still uses AbstractPlatform::supportsForeignKeyOnUpdate in AbstractPlatform::supportsForeignKeyOnUpdate
The library should never use a method it deprecated itself.
@morozov
Copy link
Member

morozov commented Oct 17, 2021 •
edited
Loading

The library should never use a method it deprecated itself.

Why?

See #4278.

@simonberger
Copy link
Contributor Author

@morozov because it triggers deprecation methods in 2.13 also when other projects use this library normally. I saw that problems like this seem to be normally solved by using triggerIfCalledFromOutside instead of trigger.

@morozov
Copy link
Member

morozov commented Oct 17, 2021 •
edited
Loading

I see, yes. AbstractPlatform::supportsForeignKeyOnUpdate() should call triggerIfCalledFromOutside(), not trigger().

@morozov morozov changed the title Deprecated method AbstractPlatform::supportsForeignKeyOnUpdate still in use A call to the non-deprecated AbstractPlatform::getAdvancedForeignKeyOptionsSQL() triggers a deprecation Oct 17, 2021
@morozov morozov added this to the 2.13.5 milestone Oct 17, 2021
simonberger added a commit to simonberger/dbal that referenced this issue Oct 17, 2021
@simonberger
doctrine#4886 Fixed calling `AbstractPlatform::getAdvancedForeignKeyO…
a466400 
…ptionsSQL` triggers a deprecation
@simonberger simonberger mentioned this issue Oct 17, 2021
Merged
@morozov morozov linked a pull request Oct 17, 2021 that will close this issue
Fix calling AbstractPlatform::getAdvancedForeignKeyOptionsSQL triggers a deprecation #4890
Merged
derrabus added a commit to derrabus/dbal that referenced this issue Oct 20, 2021
@derrabus
Merge 2.13.x into 3.1.x
92998a7 
* 2.13.x:
  Cleanup ignored PHPStan errors
  doctrine#4886 Fixed calling `AbstractPlatform::getAdvancedForeignKeyOptionsSQL` triggers a deprecation
  Add missing upcast
derrabus added a commit to derrabus/dbal that referenced this issue Oct 20, 2021
@derrabus
Merge branch '3.1.x' into 3.2.x
bc19fea 
* 3.1.x:
  Cleanup ignored PHPStan errors
  doctrine#4886 Fixed calling `AbstractPlatform::getAdvancedForeignKeyOptionsSQL` triggers a deprecation
  Add missing upcast
derrabus added a commit to derrabus/dbal that referenced this issue Oct 20, 2021
@derrabus
Merge 3.1.x into 3.2.x
99df446 
* 3.1.x:
  Cleanup ignored PHPStan errors
  doctrine#4886 Fixed calling `AbstractPlatform::getAdvancedForeignKeyOptionsSQL` triggers a deprecation
  Add missing upcast
derrabus added a commit to derrabus/dbal that referenced this issue Oct 20, 2021
@derrabus
Merge 3.2.x into 4.0.x
0d3af82 
* 3.2.x:
  Use the driver API to begin a transaction on mysqli
  Refactor MySQLi statement to make it unaware of the connection
  Cleanup ignored PHPStan errors
  doctrine#4886 Fixed calling `AbstractPlatform::getAdvancedForeignKeyOptionsSQL` triggers a deprecation
  Add missing upcast
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Deprecation Platforms
Projects
None yet
Milestone
2.13.5
2 participants
@morozov @simonberger