Migrations up() do not respect "schema" annotation variable

[guillaume-a]

Bug Report

Q	A
BC Break	no
Version	2.9.2

Summary

I'm currently working on a project with multiple databases so I specifies schema in my @table.

Current behaviour

doctrine:migration:diff`generates a migration file, but up() does not use "schema"

How to reproduce

Create an entity like this.

/**

• @Orm\Entity(repositoryClass="App\Repository\TinyElephantRepository")
• @Orm\Table(schema="sf")
  */
  class TinyElephant

Generate a diff on an existing table
Output is (simplified):

    public function up(Schema $schema) : void
    {
        $this->addSql('ALTER TABLE tiny_elephant ADD name VARCHAR(255) DEFAULT NULL');
    }

    public function down(Schema $schema) : void
    {
        $this->addSql('ALTER TABLE sf.tiny_elephant DROP name');
    }

Expected behaviour

Using schema in up() too.

    public function up(Schema $schema) : void
    {
        $this->addSql('ALTER TABLE sf.tiny_elephant ADD name VARCHAR(255) DEFAULT NULL');
    }

The issue is diff is made only from the schema and mysql do not supports "namespaces".
Regards.

[Ocramius]

@guillaume-a can you try and isolate this with just the AbstractSchemaManager?

[guillaume-a]

I'm sorry, how to do this exactly ?
Thx.

[Ocramius]

Ideally through a test scenario, but first you should look at where the culprit is (maybe with a debugger)

[guillaume-a]

Ok, i'll give a test with deep dive in the code :)

AbstractSchemaManager::listTableDetails($tableName)

returns a Table($tableName, ...)

this table does not have a _namespace because _setName($tableName) checks the '.' to separate namespace and name

Table::__construct() (call _setNam line 61)
AbstractAsset::_setName() (check '.' at line 51)

So let's back a little because AbstractSchemaManager seems to to the job.
The probleme is its caller.

AbstractSchemaManager::listTableNames()

returns [
  0 => 'migration_versions',
  1 => 'tiny_elephant',
]

Here there is no schema.
Because in mysql

$sql = $this->_platform->getListTablesSQL();

returns SHOW FULL TABLES WHERE Table_type = 'BASE TABLE' which lists tables without db name.

we have this name in :

(AbstractSchemaManager) $this->_conn->params['dbname']

Maybe add a loop here to add dbname before table name ?

Regards.

[Ocramius]

Wait, so is sf. the schema you have selected while connecting? What if you use a different schema while connecting, and then generate a migration?

[guillaume-a]

Yes, but the schema is forced with @table(schema="sf") in my entity. Legacy project with multiple databases.