Indicate support for persistence 3 #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Apr 19, 2022
derrabus
added a commit
that referenced
this pull request
Apr 19, 2022
* 1.5.x: Indicate support for persistence 3 (#387)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data-fixtures library should be compatible with version 3 of doctrine/persistence right away. I've run the test suite locally with ORM 2.12-dev and Persistence 3.0.0 and none of the ORM-related tests were failing.
The ODM is not ready yet which is why we cannot run tests with Persistence 3 in our CI yet.
Merging this PR would unlock getting support for Persistence 3 into other repositories, e.g. Symfony.