Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip test using setFilterSchemaAssetsExpression removed in DBAL3 #370

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

remicollet
Copy link
Contributor

Signed-off-by: Remi Collet remi@php.net

CI seems to only use dbal v2, so don't detect this one.

Without this patch:

There were 3 errors:

1) Doctrine\Tests\Common\DataFixtures\ORMPurgerExcludeTest::testPurgeExcludeUsingFilterExpression
Error: Call to undefined method Doctrine\ORM\Configuration::setFilterSchemaAssetsExpression()

/dev/shm/BUILD/data-fixtures-f18adf13f6c81c67a88360dca359ad474523f8e3/tests/Doctrine/Tests/Common/DataFixtures/Purger/ORMPurgerExcludeTest.php:47
/dev/shm/BUILD/data-fixtures-f18adf13f6c81c67a88360dca359ad474523f8e3/tests/Doctrine/Tests/Common/DataFixtures/Purger/ORMPurgerExcludeTest.php:77
/dev/shm/BUILD/data-fixtures-f18adf13f6c81c67a88360dca359ad474523f8e3/tests/Doctrine/Tests/Common/DataFixtures/Purger/ORMPurgerExcludeTest.php:114

2) Doctrine\Tests\Common\DataFixtures\ORMPurgerExcludeTest::testPurgeExcludeUsingList
Error: Call to undefined method Doctrine\ORM\Configuration::setFilterSchemaAssetsExpression()

/dev/shm/BUILD/data-fixtures-f18adf13f6c81c67a88360dca359ad474523f8e3/tests/Doctrine/Tests/Common/DataFixtures/Purger/ORMPurgerExcludeTest.php:47
/dev/shm/BUILD/data-fixtures-f18adf13f6c81c67a88360dca359ad474523f8e3/tests/Doctrine/Tests/Common/DataFixtures/Purger/ORMPurgerExcludeTest.php:77
/dev/shm/BUILD/data-fixtures-f18adf13f6c81c67a88360dca359ad474523f8e3/tests/Doctrine/Tests/Common/DataFixtures/Purger/ORMPurgerExcludeTest.php:122

3) Doctrine\Tests\Common\DataFixtures\ORMPurgerExcludeTest::testPurgeExcludeUsingFilterCallable
Error: Call to undefined method Doctrine\ORM\Configuration::setFilterSchemaAssetsExpression()

/dev/shm/BUILD/data-fixtures-f18adf13f6c81c67a88360dca359ad474523f8e3/tests/Doctrine/Tests/Common/DataFixtures/Purger/ORMPurgerExcludeTest.php:47
/dev/shm/BUILD/data-fixtures-f18adf13f6c81c67a88360dca359ad474523f8e3/tests/Doctrine/Tests/Common/DataFixtures/Purger/ORMPurgerExcludeTest.php:77
/dev/shm/BUILD/data-fixtures-f18adf13f6c81c67a88360dca359ad474523f8e3/tests/Doctrine/Tests/Common/DataFixtures/Purger/ORMPurgerExcludeTest.php:129

With

$ php81 /usr/bin/phpunit8 --verbose --bootstrap bootstrap.php
PHPUnit 8.5.21 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.0RC3
Configuration: /dev/shm/BUILD/data-fixtures-f18adf13f6c81c67a88360dca359ad474523f8e3/phpunit.xml.dist

......................SS........................                  48 / 48 (100%)

Time: 151 ms, Memory: 12.00 MB

There were 2 skipped tests:

1) Doctrine\Tests\Common\DataFixtures\Purger\MongoDBPurgerTest::testPurgeKeepsIndices
Missing doctrine/mongodb-odm

/dev/shm/BUILD/data-fixtures-f18adf13f6c81c67a88360dca359ad474523f8e3/tests/Doctrine/Tests/Common/DataFixtures/Purger/MongoDBPurgerTest.php:29
/dev/shm/BUILD/data-fixtures-f18adf13f6c81c67a88360dca359ad474523f8e3/tests/Doctrine/Tests/Common/DataFixtures/Purger/MongoDBPurgerTest.php:52
/dev/shm/BUILD/data-fixtures-f18adf13f6c81c67a88360dca359ad474523f8e3/tests/Doctrine/Tests/Common/DataFixtures/Purger/MongoDBPurgerTest.php:57

2) Doctrine\Tests\Common\DataFixtures\ORMPurgerExcludeTest::testPurgeExcludeUsingFilterExpression
DBAL 2 is required to test schema assets filters

/dev/shm/BUILD/data-fixtures-f18adf13f6c81c67a88360dca359ad474523f8e3/tests/Doctrine/Tests/Common/DataFixtures/Purger/ORMPurgerExcludeTest.php:93
/dev/shm/BUILD/data-fixtures-f18adf13f6c81c67a88360dca359ad474523f8e3/tests/Doctrine/Tests/Common/DataFixtures/Purger/ORMPurgerExcludeTest.php:122

OK, but incomplete, skipped, or risky tests!
Tests: 48, Assertions: 117, Skipped: 2.

Signed-off-by: Remi Collet <remi@php.net>
@remicollet
Copy link
Contributor Author

Please add the hacktoberfest topic

@derrabus derrabus added this to the 1.5.2 milestone Oct 5, 2021
@derrabus derrabus merged commit c539e66 into doctrine:1.5.x Oct 5, 2021
@derrabus
Copy link
Member

derrabus commented Oct 5, 2021

Thank you!

@remicollet remicollet deleted the issue-dbal3 branch October 5, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants