Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DBAL 3 compatibility #366

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Fix DBAL 3 compatibility #366

merged 1 commit into from
Sep 20, 2021

Conversation

williarin
Copy link
Contributor

Fixes #365

doctrine:fixtures:load command no longer failing with DBAL 3.

@greg0ire greg0ire added the Bug label Sep 19, 2021
@greg0ire
Copy link
Member

greg0ire commented Sep 19, 2021

To make this complete, I think we should allow dbal 3 the version constraint here:

"doctrine/dbal": "^2.5.4",

Currently, we are only testing with doctrine/dbal v2 because of it.

greg0ire
greg0ire previously approved these changes Sep 19, 2021
@greg0ire greg0ire added this to the 1.5.1 milestone Sep 19, 2021
@greg0ire
Copy link
Member

greg0ire commented Sep 19, 2021

Maybe I approved too fast… what does this PR do?
I think it means that when upgrading to DBAL 3, tables that were previously not purged will suddenly be purged, correct?

EDIT: and then I click "Close and comment" when I mean to click comment 😅

@greg0ire greg0ire closed this Sep 19, 2021
@greg0ire greg0ire reopened this Sep 19, 2021
@greg0ire greg0ire dismissed their stale review September 19, 2021 16:28

The UPGRADE guide states the following: "Regular expression-based filters are hard to extend by combining together. Instead, you may use callback-based filers via ::getSchemaAssetsFilter() and ::getSchemaAssetsFilter(). Callbacks can use regular expressions internally.". This is not what this PR does.

@stof
Copy link
Member

stof commented Sep 19, 2021

Maybe I approved too fast… what does this PR do?
I think it means that when upgrading to DBAL 3, tables that were previously not purged will suddenly be purged, correct?

Well, doctrine/data-fixtures does not configure the filtering. It uses the filtering configured in DBAL.
If you use the filtering feature of your project, you will already need to migrate to the non-deprecated feature before migrating to DBAL 3.

@greg0ire
Copy link
Member

Oh right, I didn't notice that the new way was already handled in the lines below (because I didn't know what it looked like). It should be fine then I think.

@greg0ire greg0ire merged commit f18adf1 into doctrine:1.5.x Sep 20, 2021
@greg0ire
Copy link
Member

Thanks @williarin !

@williarin williarin deleted the fix-dbal3-compatibility branch September 21, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading fixtures fails with DBAL 3
4 participants