-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DBAL 3 compatibility #366
Conversation
To make this complete, I think we should allow dbal 3 the version constraint here: Line 27 in d5ebdb4
Currently, we are only testing with |
Maybe I approved too fast… what does this PR do? EDIT: and then I click "Close and comment" when I mean to click comment 😅 |
The UPGRADE guide states the following: "Regular expression-based filters are hard to extend by combining together. Instead, you may use callback-based filers via ::getSchemaAssetsFilter() and ::getSchemaAssetsFilter(). Callbacks can use regular expressions internally.". This is not what this PR does.
Well, doctrine/data-fixtures does not configure the filtering. It uses the filtering configured in DBAL. |
Oh right, I didn't notice that the new way was already handled in the lines below (because I didn't know what it looked like). It should be fine then I think. |
Thanks @williarin ! |
Fixes #365
doctrine:fixtures:load
command no longer failing with DBAL 3.