Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to exclude tables from purge in ORM #225

Merged
merged 11 commits into from
Jul 5, 2016
Merged

Add ability to exclude tables from purge in ORM #225

Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0518ee3
Added the option to exclude tables/views from purge
Jun 15, 2016
7a5694d
syntax error correction
Jun 15, 2016
0fbd580
Add exclude option to purge
Jun 15, 2016
79754da
check filter schema
Jun 15, 2016
7938337
Fix test
Jun 15, 2016
cc5d23b
Smaller test
Jun 16, 2016
a6a0445
Merge branch 'excluded-tables'
Jun 16, 2016
a242972
Add tests
Jul 4, 2016
9eada6e
Merge branch 'excluded-tables-tests' into excluded-tables
Jul 4, 2016
01959a2
Created independent entities for testing to avoid conflicts.
Jul 4, 2016
c981606
Merge branch 'excluded-tables'
Jul 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions lib/Doctrine/Common/DataFixtures/Purger/ORMPurger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,23 @@ class ORMPurger implements PurgerInterface
*/
private $purgeMode = self::PURGE_MODE_DELETE;

/**
* Table/view names to be excleded from purge
*
* @var string[]
*/
private $excluded;

/**
* Construct new purger instance.
*
* @param EntityManagerInterface $em EntityManagerInterface instance used for persistence.
* @param string[] $excluded array of table/view names to be excleded from purge
*/
public function __construct(EntityManagerInterface $em = null)
public function __construct(EntityManagerInterface $em = null, array $excluded = array())
{
$this->em = $em;
$this->excluded = $excluded;
}

/**
Expand Down Expand Up @@ -133,11 +142,15 @@ public function purge()
}

$connection = $this->em->getConnection();
$filterExpr = $connection->getConfiguration()->getFilterSchemaAssetsExpression();
$efe = empty($filterExpr);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does efe mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty filter expression

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not abbreviate then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, i changed the variable name and added tests for exclusion using the filter expression or the explicit exclusion list.

foreach($orderedTables as $tbl) {
if ($this->purgeMode === self::PURGE_MODE_DELETE) {
$connection->executeUpdate('DELETE FROM ' . $tbl);
} else {
$connection->executeUpdate($platform->getTruncateTableSQL($tbl, true));
if(($efe||( !$efe && preg_match($filterExpr, $tbl) )) && array_search($tbl, $this->excluded) === false){
if ($this->purgeMode === self::PURGE_MODE_DELETE) {
$connection->executeUpdate('DELETE FROM ' . $tbl);
} else {
$connection->executeUpdate($platform->getTruncateTableSQL($tbl, true));
}
}
}
}
Expand Down Expand Up @@ -238,4 +251,4 @@ private function getJoinTableName($assoc, $class, $platform)

return $this->em->getConfiguration()->getQuoteStrategy()->getJoinTableName($assoc, $class, $platform);
}
}
}