Skip to content

Commit

Permalink
Add typehint
Browse files Browse the repository at this point in the history
  • Loading branch information
VincentLanglet committed Oct 23, 2022
1 parent ab2a4c8 commit 0a88983
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 14 deletions.
10 changes: 4 additions & 6 deletions lib/Doctrine/Common/DataFixtures/AbstractFixture.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,16 +72,15 @@ public function addReference($name, $object)
*
* @see Doctrine\Common\DataFixtures\ReferenceRepository::getReference
*
* @param string $name
* @param string|null $class
* @param string $name
* @psalm-param class-string<T>|null $class
*
* @return object
* @psalm-return $class is null ? object : T
*
* @template T of object
*/
public function getReference($name, $class = null)
public function getReference($name, ?string $class = null)
{
if ($class === null) {
Deprecation::trigger(
Expand All @@ -101,13 +100,12 @@ public function getReference($name, $class = null)
*
* @see Doctrine\Common\DataFixtures\ReferenceRepository::hasReference
*
* @param string $name
* @param string|null $class
* @param string $name
* @psalm-param class-string $class
*
* @return bool
*/
public function hasReference($name, $class = null)
public function hasReference($name, ?string $class = null)
{
if ($class === null) {
Deprecation::trigger(
Expand Down
14 changes: 6 additions & 8 deletions lib/Doctrine/Common/DataFixtures/ReferenceRepository.php
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ public function setReference($name, $reference)
*
* @return void
*/
public function setReferenceIdentity($name, $identity, $class = null)
public function setReferenceIdentity($name, $identity, ?string $class = null)
{
if ($class === null) {
Deprecation::trigger(
Expand Down Expand Up @@ -202,8 +202,7 @@ public function addReference($name, $object)
* Loads an object using stored reference
* named by $name
*
* @param string $name
* @param string|null $class
* @param string $name
* @psalm-param class-string<T>|null $class
*
* @return object
Expand All @@ -213,7 +212,7 @@ public function addReference($name, $object)
*
* @template T of object
*/
public function getReference($name, $class = null)
public function getReference($name, ?string $class = null)
{
if ($class === null) {
Deprecation::trigger(
Expand Down Expand Up @@ -259,13 +258,12 @@ public function getReference($name, $class = null)
* Check if an object is stored using reference
* named by $name
*
* @param string $name
* @param string|null $class
* @param string $name
* @psalm-param class-string $class
*
* @return bool
*/
public function hasReference($name, $class = null)
public function hasReference($name, ?string $class = null)
{
if ($class === null) {
Deprecation::trigger(
Expand Down Expand Up @@ -307,7 +305,7 @@ public function getReferenceNames($reference)
*
* @return bool
*/
public function hasIdentity($name, $class = null)
public function hasIdentity($name, ?string $class = null)
{
if ($class === null) {
Deprecation::trigger(
Expand Down

0 comments on commit 0a88983

Please sign in to comment.