This repository was archived by the owner on Feb 5, 2024. It is now read-only.
Some fixes to get valid JSON in response #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@zorn-v what's the reason for trimming inside the while() loop and after it? |
|
Don't know purpose for last trim, just replace ugly analog 😄 That JSON become invalid |
zorn-v
commented
Apr 27, 2017
| @@ -290,6 +290,7 @@ public function request($method, $path, $data = null, $raw = false, array $heade | |||
| while ($bytesLeft > 0) { | |||
| $body .= $read = fread($this->connection, $bytesLeft + 2); | |||
| $bytesLeft -= strlen($read); | |||
| $body = substr($body, 0, -2); | |||
There was a problem hiding this comment.
After review I'm understand that trimming is not good idea. In 2 line above we read 2 additional symbols and we need to trim they only.
Otherwise it may trim spaces/tabs/etc that actualy was in that json.
zorn-v
commented
Apr 27, 2017
| } | ||
| } | ||
| } while ($bytesToRead > 0); | ||
|
|
||
| // Chop off \r\n from the end. | ||
| $body = substr($body, 0, -2); |
There was a problem hiding this comment.
We already removed that symbols in while loop, and there we just make JSON become invalid again.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.