Convert proxy factory auto generate mode to integer #816
Conversation
| self::AUTOGENERATE_NEVER, | ||
| self::AUTOGENERATE_ALWAYS, | ||
| self::AUTOGENERATE_FILE_NOT_EXISTS, | ||
| self::AUTOGENERATE_EVAL |
There was a problem hiding this comment.
There should be comma after last item.
| */ | ||
| public function __construct(ProxyGenerator $proxyGenerator, ClassMetadataFactory $metadataFactory, $autoGenerate) | ||
| { | ||
| $this->proxyGenerator = $proxyGenerator; | ||
| $this->metadataFactory = $metadataFactory; | ||
| $this->autoGenerate = (bool)$autoGenerate; | ||
|
|
||
| if ( ! in_array($autoGenerate, self::AUTOGENERATE_MODES, false)) { |
There was a problem hiding this comment.
You don't need false here as it's default behavior.
There was a problem hiding this comment.
It is the default value, but I wanted to be explicit that we allow other values
There was a problem hiding this comment.
And why not casting it to int and making a strict comparison?
There was a problem hiding this comment.
Normally I don't set properties until they are validated. But I guess in this case makes no difference as it's the constructor
|
@dragosprotung there are some CS violations, I've just pushed #817 to update our build process and verify coding standard violations. Do you want me to point out the issues or do you prefer to wait for it to be merged and just use |
|
@lcobucci I can see them from your PR, but I will wait for it to be merged if it will not take too long |
|
@lcobucci let's not pick on CS if a massive conflicting PR is coming in anyway :-P |
| @@ -69,6 +69,13 @@ | |||
| */ | |||
| const AUTOGENERATE_EVAL = 3; | |||
|
|
|||
| private const AUTOGENERATE_MODES = [ | |||
Clean PR based on #815