Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix __call exception when no metadata has been set #792

Merged
merged 1 commit into from
Jul 22, 2017
Merged

Fix __call exception when no metadata has been set #792

merged 1 commit into from
Jul 22, 2017

Conversation

ostrolucky
Copy link
Member

@ostrolucky ostrolucky commented Apr 30, 2017 •
edited
Loading

This makes sure $cm is set before trying to call it in throw block
closes #139

Ocramius
Ocramius suggested changes May 2, 2017
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch requires test changes.

@Ocramius Ocramius added the Bug label May 2, 2017
@ostrolucky
Copy link
Member Author

What test changes? You mean writing new test?

@Ocramius
Copy link
Member

Ocramius commented May 2, 2017 via email

@ostrolucky
Fix __call exception when no metadata has been set
db897a0 
This makes sure $cm is set before trying to call it in catch block
closes #139
@ostrolucky
Copy link
Member Author

test added

@Ocramius Ocramius self-assigned this Jul 22, 2017
@Ocramius Ocramius added this to the 2.7.3 milestone Jul 22, 2017
@Ocramius
Copy link
Member

Thanks @ostrolucky!

@Ocramius Ocramius merged commit 91daa02 into doctrine:master Jul 22, 2017
Ocramius added a commit that referenced this pull request Jul 22, 2017
@Ocramius
Merge branch 'fix/#139-#792-fix-magic-__call-when-no-metadata-has-bee…
407abe1 
…n-set' into 2.7

Backport #139
Backport #792
@Ocramius
Copy link
Member

Backported via 407abe1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius requested changes

Assignees

@Ocramius Ocramius

Labels
Bug
Projects
None yet
Milestone
2.7.3
Development

Successfully merging this pull request may close these issues.

generation of error message fails under certain circumstances
2 participants
@ostrolucky @Ocramius