fix the optimize regex and adapt the tests to actually test classAnnotat...

[dawehner]

There has been several problems

• Even we enabled classAnnotationOptimized we expected a different behavior: You cannot parse properties any longer (fixed that by expecting an exception). Therefore moved the test data into a provider so you can check the exception on each of them.
• Once done I realized that DeeperNamespaceParent had the wrong className
• Additional I added a test to check that the regex matched.
  StaticReflectionParser::parse regexp is not inclusive enough #307

[doctrinebot]

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DCOM-223

We use Jira to track the state of pull requests and the versions they got
included in.

[Ocramius]

As stated in previous discussion, we don't do this sort of "coding to make it testable" - If there's no way to verify that it's working because there's no change in behavior, then let's just harden the existing tests with more cases

[dawehner]

Fixed now

[chx]

we don't do this sort of "coding to make it testable" - If there's no way to verify that it's working because there's no change in behavior, then let's just harden the existing tests with more cases

Aye but now you can't verify whether the optimization works and that's pretty bad for Drupal. Just hope it's not broken this time?

[Ocramius]

@chx check it out in the environment where stuff breaks and see if the fix does it for you :-)

[chx]

It doesn't break because it's an optimization! It just consumes an unholy amount of memory. Some people reported 600mb on longer classes.

[Ocramius]

@chx yes, I'm saying that checking it out in those environments and monitoring memory usage is the way to go to verify the patch

[chx]

Would you then accept a patch here which feeds a, say, 10mb string to the parser and checks memory_get_peak_usage?

[Ocramius]

@chx if we can use stuff like str_repeat, then probably yes.

[dawehner]

@chx
The new test ensures that parsing the properties does not work, aka. the code is not loaded at all.

[chx]

Ah, awesome! Let's get this into to Drupal then!

[Ocramius]

@guilhermeblanco can we get this merged?

[dawehner]

Thank you!