Updated doctrine/coding-standard to 6.0#178
Merged
Ocramius merged 1 commit intodoctrine:masterfrom Mar 17, 2019
patrickjahns:bump-coding-standard
Merged
Updated doctrine/coding-standard to 6.0#178Ocramius merged 1 commit intodoctrine:masterfrom patrickjahns:bump-coding-standard
Ocramius merged 1 commit intodoctrine:masterfrom
patrickjahns:bump-coding-standard
Conversation
Signed-off-by: Patrick Jahns <github@patrickjahns.de>
Ocramius
suggested changes
Mar 17, 2019
|
|
||
| return static function ($a, $b) use ($name, $next, $orientation) : int { | ||
| $aValue = ClosureExpressionVisitor::getObjectFieldValue($a, $name); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
If I revert the change - codesniffer screams:
FILE: lib/Doctrine/Common/Collections/Expr/ClosureExpressionVisitor.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
104 | ERROR | [x] Expected 1 lines after "return", found 0.
| | (SlevomatCodingStandard.ControlStructures.ControlStructureSpacing.IncorrectLinesCountAfterControlStructure)
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Need to have a closer look into the slevomat rules to figure out whats going wrong here
Member
There was a problem hiding this comment.
Could you reproduce this and report it to doctrine/coding-standard maybe? We can roll with this patch meanwhile 👍
Contributor
Author
There was a problem hiding this comment.
Boiled it down to a simple example and open report here: slevomat/coding-standard#635
Ocramius
approved these changes
Mar 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated coding-standard and used
phpcbfto automatically fix them