Skip to content

Allow using doesNotPerformAssertions annotations #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Mar 1, 2018

The annotation is used in PHPUnit tests to mark tests without assertions as "not risky".

Note: dev-master currently contains changes that would constitute a BC break. I'd like to tag this as either 3.0.1 or 3.1.0 since I believe we should accumulate more changes before tagging 4.0.0. Opinions?

The annotation is used in PHPUnit tests to mark tests without assertions as "not risky"
@alcaeus alcaeus self-assigned this Mar 1, 2018
Copy link
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the annotation!

Note: dev-master currently contains changes that would constitute a BC break. I'd like to tag this as either 3.0.1 or 3.1.0 since I believe we should accumulate more changes before tagging 4.0.0.

We current have only one pending change in dev-master, and we are just waiting for slevomat 4.5 for some new Sniffers, so 👎 for creating 3.1 just for this annotation IMHO

@Ocramius
Copy link
Member

Ocramius commented Mar 1, 2018

Merging to 4.0.0.

For the backporting: it can be done, but is it really worth doing?

@Ocramius Ocramius added this to the 4.0.0 milestone Mar 1, 2018
@Ocramius Ocramius merged commit 5ee7ecc into master Mar 1, 2018
@Ocramius Ocramius deleted the allow-assertion-doc-comment branch March 1, 2018 06:36
@alcaeus
Copy link
Member Author

alcaeus commented Mar 1, 2018

but is it really worth doing

depends on the timeline for 4.0.0. I can of course take that entire rule block and copy it to the phpcs config in ODM, but I'd rather avoid that kind of duplication.

@Ocramius
Copy link
Member

Ocramius commented Mar 1, 2018

@alcaeus considering how fast we are at changing stuff here, I wouldn't be too worried about timelines (for now) :)

@kukulich
Copy link
Contributor

kukulich commented Mar 1, 2018

I think 4.0.0 can be released next week if #21 is postponed again.

Slevomat CS with bunch of new sniffs can be released early. I wait only for two new sniffs promised from @Majkl578 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants