-
-
Notifications
You must be signed in to change notification settings - Fork 212
Fix delete() and flushAll() #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the cleanup was missing to remove the cache root dir thus every test run would create a new temp dir without deleting it.
|
Some cache providers fail the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is indeed painful :|
|
@Ocramius I fixed all drivers that were failing for deleting non-existing entries. The cache suit passes now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test ignored the data provider as $value has not been used at all.
|
Merged and backported into |
unlinkreturns false if the file does not exist. This was also broken for some other cache drivers..and..(if the extension is empty) trying to delete them, which of course failed, but was silenced. and intermediate directories for balancing were never removed. flushAll only removed the files but not the directories leaving alot of garbage behind.falseas data