Skip to content

Corrected return type of PredisCache#doContains(), which should be bool (was int) #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ocramius merged 1 commit into from
Jul 15, 2016
Merged

Corrected return type of PredisCache#doContains(), which should be bool (was int) #167

Ocramius merged 1 commit into from
Jul 15, 2016

Conversation

@localheinz
Copy link
Contributor

@localheinz localheinz commented Jul 15, 2016

This PR

  • assumes that Redis::exists() returns 0 if the cache doesn't contain data for an $id

💁 For reference, see http://redis.io/commands/EXISTS#return-value.

@Ocramius Ocramius self-assigned this Jul 15, 2016
@Ocramius Ocramius added the Bug label Jul 15, 2016
@Ocramius Ocramius added this to the 1.7.0 milestone Jul 15, 2016
@Ocramius Ocramius merged commit 39129b3 into doctrine:master Jul 15, 2016
@Ocramius
Copy link
Member

Ocramius commented Jul 15, 2016

@localheinz thanks!

@localheinz localheinz deleted the fix/build branch July 15, 2016 15:00
@Ocramius Ocramius changed the title Fix: exists() returns an integer Corrected return type of PredisCache#doContains(), which should be bool (was int) Jul 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Ocramius Ocramius

Labels

Bug

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@localheinz @Ocramius