skip query when there is no valid id

[uwej711]

see my comment on the source code of the commit that introduced that f393c06

[dbu]

we can ignore styleci on the 1.2 branch. and the build is actually ok, only deprecation warnings. we might need to backport the deprecation ignore thing to 1.2.

are you code-wise sure that this is fine to do? there is no test for this situation, may i ask you to add one?

[uwej711]

The loader ist tested, but not for the case with an empty id, but sure i can add a test for that.

[uwej711]

Just tried to add a test but the error only seems to be there when you use jackrabbit as the backend. Maybe it's actually an issue there. We could still leave this as an optimization as there is no need to query empty ids ...

[uwej711]

See doctrine/phpcr-odm#662

[dbu]

the only failure i see is https://travis-ci.org/doctrine/DoctrinePHPCRBundle/jobs/82953994 which looks like a symfony version issue. am i confused now.

the other builds are red because deprecation warnings.

[lsmith77]

I have now disabled styleci for the 1.0, 1,1 and 1.2 branches

[dbu]

thanks. can you also make the 1.2 branch not consider symfony warnings as errors please?

[lsmith77]

@dbu what warnings, where?

[dbu]

twig deprecation warnings, as in https://travis-ci.org/doctrine/DoctrinePHPCRBundle/jobs/82953979 - they make the test marked as failed while it seems ok for maintenance to use those. we don't want to do BC workarounds here.

[lsmith77]

i guess that needs to be done in the .travis.yml

[dbu]

for the warnings, see #217