Fix to lastItemNumber in Paginator #79
Conversation
Since the cursor returns the wrong count, we return an array. I have updated the unit test to work with array return type. There is a new unit test to test the counts.
|
@jmikola are we fine here then? |
|
The ODM dependency should likely be bumped to 1.0.0-BETA9, as that contained the fix for this. EDIT: Actually, now that I think about it, there wasn't really anything in ODM to fix this, was there? |
| $this->assertEquals(sprintf('Document %02d', $i), current($documents)->getName()); | ||
| next($documents); | ||
| } | ||
| $this->assertEquals(false, next($documents)); |
There was a problem hiding this comment.
It may be clearer to use $this->assertCount(5, $documents);.
|
Just did a thorough pass. I'll leave it up to @Ocramius to decide what feedback is worth addressing. Thanks for the work on this. |
|
Are we waiting on me for this? |
|
@levofski yep :) But nobody will hunt you down ;) |
|
Ah ok, I will go through the comments as soon as I can. |
|
Hey @levofski do you still have this in sight or should it be reassigned? |
|
Hiya sorry I am really pushed recently, if it can be reassigned that might be best. |
|
Closing. Handled by #98 |
Since the cursor returns the wrong count, we return an array. I have
updated the unit test to work with array return type. There is a new
unit test to test the counts.