-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropped PHP 7.2, added PHP 8.0 #241
Conversation
5080b8f
to
56eb1f9
Compare
195d68f
to
75d21f5
Compare
75d21f5
to
ee327ce
Compare
Somehow, this project doesn't run yet with PHP 8.1. I tried that, but CI fails for (only) PHP 8.1 with the following error:
See https://github.com/doctrine/DoctrineMongoODMModule/actions/runs/1452450213 for the full CI run. I tried tackeling this issue down, but wasn't successful yet. As I cannot spend any further time on this right now, I suggest that we merge this with support for PHP 8.0 only, i.e. without support for PHP 8.1. This will still be a benefit for users and we can look at PHP 8.1 later again. |
@@ -6,7 +6,7 @@ | |||
|
|||
use Doctrine\Laminas\Hydrator\DoctrineObject; | |||
use Doctrine\ODM\MongoDB\DocumentManager; | |||
use Psr\Container\ContainerInterface; | |||
use Interop\Container\ContainerInterface; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the benefit of this change?
Starting Feb. 13th 2017, container-interop is officially deprecated in favor of PSR-11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FactoryInterface from the latest Laminas ServiceManager still uses Interop\Container\ContainerInterface
. Hence, whenever implementing the Laminas interfaces, we are using Interop's ContainerInterface.
I wanted to keep this consistent so that we only need to require one of container-interop/container-interop
and psr/container
. Otherwise, we'd need to require both.
0ac5ca4
to
50022b4
Compare
50022b4
to
ab01449
Compare
thanks, @driehle for picking this up! 🙏 |
PHP 7.2 is dropped because it is not support by our upstream dependencies anymore. For instance, many laminas componets have already dropped PHP 7.2 a while ago and recently we also dropped PHP 7.2 in DoctrineModule.