Improvement to IDE-friendliness when 'wrapper_class' option is used

[Xymanek]

Sets the class property in service definition to assist IDEs in knowing what class the service really is. Since connection services use a factory, the class option doesn't affect anything. I've tested the logic with following "hack" and it works without any problems:

class DataConnectionCompilerPass implements CompilerPassInterface
{
    public function process (ContainerBuilder $container)
    {
        $service = $container->findDefinition('doctrine.dbal.data_connection');
        $service->setClass(DataConnectionWrapper::class);
    }
}

P.S. Why so many privates in \Doctrine\DBAL\Connection? Makes extending it so hard....

[stloyd]

assertNull()

[Xymanek]

Ooops

[Xymanek]

Anything else? Don't want to pollute with commits

[Ocramius]

P.S. Why so many privates in \Doctrine\DBAL\Connection? Makes extending it so hard....

It's not meant to be extended.

[Xymanek]

Anything else needs to be done?

[weaverryan]

@Xymanek Can you resolve the conflict?

[weaverryan]

I would move this up to after line 211 - so right after $def =

[weaverryan]

+1 The wrapperClass option is ultimately used in the DBAL to create a class of that specific instance. So, yea, technically, the definition's should match the actual class that will be created.

[Xymanek]

@weaverryan Fixed and fixed

[Ocramius]

@Xymanek can you please rebase instead of merging master? Commit Xymanek/DoctrineBundle@1245734 should go away

[Xymanek]

@Ocramius can you please give me a hint on how to do that? I kinda know what you mean but not sure how to do it cross-repository...

[Ocramius]

@Xymanek I'll do that now while merging :-)

If you never did it before, consider reading https://www.atlassian.com/git/tutorials/rewriting-history

[Ocramius]

Manually rebased and merged via 1818d3d

Thanks @Xymanek!