Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue were some commented type #623

Merged
merged 2 commits into from
Feb 23, 2017

Conversation

mikeSimonson
Copy link
Contributor

They were not marked as such if the mappingType array was
empty.

Sadly I don't see any way to test this right now.

They were not marked as such if the mappingType array was
empty.

Sadly I don't see any way to test this right now.
@stof
Copy link
Member

stof commented Feb 22, 2017

IMO, we should deprecate this entirely. Types can be marked as commented inside themselves as of DBAL 2.3 or 2.4 (I don't remember anymore), which is much better, because it does not require getting the platform early.

@mikeSimonson
Copy link
Contributor Author

This is related to #618
Do you think that the issue is somewhere else because apparently the user use a type class that is marked as using a comment.
The issue might be in the EnumBundle but I couldn't reproduce it despite very creative attempts.

@mikeSimonson mikeSimonson self-assigned this Feb 22, 2017
@mikeSimonson
Copy link
Contributor Author

@stof It still fixed a few test that were apparently not running for some reason.

@mikeSimonson
Copy link
Contributor Author

@stof Maybe we can add a deprecation when https://github.com/doctrine/DoctrineBundle/blob/master/ConnectionFactory.php#L83 is reached ?

@stof
Copy link
Member

stof commented Feb 22, 2017

is there really no failure in DBAL when a non-existent class name is used for a type ?

@mikeSimonson
Copy link
Contributor Author

@stof I didn't really tried understanding how that test passed in past but I am guessing one way or another this part wasn't run as the error is from PHP itself.

@mikeSimonson
Copy link
Contributor Author

@stof For the deprecation notice I suppose we also need to change this default config.
https://github.com/doctrine/DoctrineBundle/blob/master/DependencyInjection/Configuration.php#L100

If I do that I suppose I should wait for a 2.0 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants