-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an issue were some commented type #623
Conversation
They were not marked as such if the mappingType array was empty. Sadly I don't see any way to test this right now.
IMO, we should deprecate this entirely. Types can be marked as commented inside themselves as of DBAL 2.3 or 2.4 (I don't remember anymore), which is much better, because it does not require getting the platform early. |
This is related to #618 |
@stof It still fixed a few test that were apparently not running for some reason. |
@stof Maybe we can add a deprecation when https://github.com/doctrine/DoctrineBundle/blob/master/ConnectionFactory.php#L83 is reached ? |
is there really no failure in DBAL when a non-existent class name is used for a type ? |
@stof I didn't really tried understanding how that test passed in past but I am guessing one way or another this part wasn't run as the error is from PHP itself. |
@stof For the deprecation notice I suppose we also need to change this default config. If I do that I suppose I should wait for a 2.0 ? |
3d41850
to
1414418
Compare
They were not marked as such if the mappingType array was
empty.
Sadly I don't see any way to test this right now.