Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating sqlite database #483

Merged
merged 1 commit into from
Nov 16, 2015
Merged

Conversation

hason
Copy link
Contributor

@hason hason commented Nov 5, 2015

Fixes #482.

@j0k3r
Copy link

j0k3r commented Nov 8, 2015

👍 for this!

@kingcrunch
Copy link
Contributor

Hi @hason

Like I mentioned in #434, although it works I don't think it's the right approach to use the path from the URL (which in fact is the database name) to find, whether or not the database name should be quoted. [1] Imo you should use driver to find out, whether or not SQLite is used. What do you think?

[1] I need to verify this, because I thought, that maybe I am totally wrong an path is indeed the path to the SQLite-DB and not the path from the URL. However, my point, that I'd test against driver remains 😄

@emmanuelballery
Copy link

👍 huge BC for us :/

@matteosister
Copy link

please merge this and tag a new release. Thanks.

@wouterj
Copy link
Contributor

wouterj commented Nov 13, 2015

👍 This is breaking our CMF builds :(

@j0k3r
Copy link

j0k3r commented Nov 13, 2015

ping @guilhermeblanco :)

@jimmycleuren
Copy link

👍 please merge

@guilhermeblanco guilhermeblanco self-assigned this Nov 16, 2015
guilhermeblanco added a commit that referenced this pull request Nov 16, 2015
Fix creating sqlite database
@guilhermeblanco guilhermeblanco merged commit c4ffef2 into doctrine:master Nov 16, 2015
@j0k3r j0k3r mentioned this pull request Nov 16, 2015
@slashfan
Copy link

+1 for a tag thanks :)

@pawaclawczyk
Copy link

+1 for tag
ping @guilhermeblanco

@guilhermeblanco
Copy link
Member

@j0k3r
Copy link

j0k3r commented Dec 1, 2015

@guilhermeblanco thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants