Skip to content

Update entity-listeners.rst #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2015
Merged

Update entity-listeners.rst #390

merged 1 commit into from
Feb 12, 2015

Conversation

luciantugui
Copy link
Contributor

code blocks are visible now

Ocramius added a commit that referenced this pull request Feb 12, 2015
Update entity-listeners.rst
@Ocramius Ocramius merged commit 67057b2 into doctrine:master Feb 12, 2015
@Ocramius
Copy link
Member

Thanks!

@Ocramius Ocramius added the Bug label Feb 12, 2015
@Ocramius Ocramius self-assigned this Feb 12, 2015
@xabbuh
Copy link
Member

xabbuh commented Feb 13, 2015

@luciantugui @Ocramius You now have two code blocks and not the nice tabbed view the Symfony documentation uses everywhere else. Furthermore, due to the indentation, the code blocks are no rendered as blockquotes (see http://symfony.com/doc/master/bundles/DoctrineBundle/entity-listeners.html). Is that intended?

@luciantugui
Copy link
Contributor Author

@xabbuh new PR

@stof
Copy link
Member

stof commented Feb 13, 2015

This should be reverted. It is breaking the doc on symfony.com, which is the place for which we intend to render it (github.com rendering of rST file is incomplete anyway)

stof added a commit that referenced this pull request Feb 13, 2015
This reverts commit 67057b2, reversing
changes made to 89196a1.
@luciantugui
Copy link
Contributor Author

@stof this PR should fix it for both

@stof stof mentioned this pull request Feb 13, 2015
@stof
Copy link
Member

stof commented Feb 13, 2015

no it does not. Displaying different formats below each other is not what we want on symfony.com. It is not consistent.
I reverted the merge in ff5eaef and changed the doc link in the readme in 0162e00

@luciantugui
Copy link
Contributor Author

ok, sorry for removing configuration block, got it now, although it's still not rendered correctly: entity listeners

as a side note, can entity listeners be mentioned in the cookbook entry regarding event listeners and subscribers? thanks

@xabbuh
Copy link
Member

xabbuh commented Feb 13, 2015

ok, sorry for removing configuration block, got it now, although it's still not rendered correctly: entity listeners

@luciantugui The documentation has not been regenerated since the last change.

as a side note, can entity listeners be mentioned in the cookbook entry regarding event listeners and subscribers? thanks

Can you open a pull request or create an issue on the Symfony documentation repository?

@Ocramius
Copy link
Member

@stof sorry, thought this kind of separate view was intentional, so I didn't think too much about it before merging. Thanks for reverting :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants