Skip to content

Add option "doctrine.orm.enable_lazy_ghost_objects" #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2022
Merged

Add option "doctrine.orm.enable_lazy_ghost_objects" #1568

merged 1 commit into from
Dec 23, 2022

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Oct 30, 2022

Sidekick of doctrine/orm#10187

@nicolas-grekas nicolas-grekas changed the title Enable attaching an entity listener without specifying an event Add option "doctrine.orm.enable_lazy_ghost_objects" Oct 30, 2022
@nicolas-grekas nicolas-grekas force-pushed the lazy- branch 3 times, most recently from 0d3429e to fab5f63 Compare October 30, 2022 10:12
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 30, 2022
Merged
@ostrolucky
Copy link
Member

ostrolucky commented Oct 30, 2022

LGTM, but upstream PR should be merged first

@derrabus derrabus added Feature Status: On Hold Most likely waiting for upstream resolution labels Nov 1, 2022
@stof stof removed the Status: On Hold Most likely waiting for upstream resolution label Dec 9, 2022
@stof
Copy link
Member

stof commented Dec 9, 2022

The upstream PR is merged

@stof stof added the Status: On Hold Most likely waiting for upstream resolution label Dec 9, 2022
@stof
Copy link
Member

stof commented Dec 9, 2022

We might want to wait for a release though

@ostrolucky
Copy link
Member

ostrolucky commented Dec 10, 2022

what about documenting this, at least by ading option description?

derrabus
derrabus reviewed Dec 11, 2022
View reviewed changes
@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Dec 12, 2022

what about documenting this, at least by ading option description?

I was about to add this but I think it's quite difficult to convey something useful for now.
I'd suggest waiting for doctrine/common to deprecate its proxies before.
And then to deprecate not setting the new setting to true later on.

@nicolas-grekas nicolas-grekas force-pushed the lazy- branch 4 times, most recently from 5e69d5f to 21d57e2 Compare December 21, 2022 16:16
@derrabus derrabus added this to the 2.8.0 milestone Dec 22, 2022
@derrabus derrabus removed the Status: On Hold Most likely waiting for upstream resolution label Dec 22, 2022
@derrabus
Copy link
Member

derrabus commented Dec 22, 2022

Upstream PR has been released with ORM 2.14.0.

@stof stof merged commit 79fb012 into doctrine:2.8.x Dec 23, 2022
@nicolas-grekas nicolas-grekas deleted the lazy-👻 branch January 12, 2023 08:49
@mvhirsch mvhirsch mentioned this pull request May 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derrabus derrabus derrabus approved these changes

Assignees

No one assigned

Labels

Feature

Projects

None yet

Milestone

2.8.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas @ostrolucky @stof @derrabus @segli