Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console commands prefer 'master' over ' primary' when using Slaves #1257

Closed
prengerjarno opened this issue Nov 12, 2020 · 2 comments
Closed
Milestone

Comments

@prengerjarno
Copy link
Contributor

Following #1215 and doctrine/dbal#4295, the console commands now support the new 'primary' config while the MasterSlaveConnection also has BC support for 'master'. This now leads to the console commands using the 'master' config which is missing the driver option.

I think it can simple prefer the 'primary' config.

prengerjarno added a commit to prengerjarno/DoctrineBundle that referenced this issue Nov 12, 2020
@ostrolucky
Copy link
Member

This looks like same issue as here #1252

What version are you using?

@prengerjarno
Copy link
Contributor Author

@ostrolucky I thought that at first as well, but after the fix in #1252 i still am missing the 'driver' param when using the create and drop commands, which results in not being able to create the connection. With the PrimaryReadReplicaConnection this is explicitly added to the primary/replica params.

I am using 1.12.12

@ostrolucky ostrolucky added this to the 1.12.13 milestone Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants