-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate annotation-specific properties in the Sluggable extension annotation/attribute classes #2837
Deprecate annotation-specific properties in the Sluggable extension annotation/attribute classes #2837
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2837 +/- ##
=======================================
Coverage 78.66% 78.66%
=======================================
Files 167 167
Lines 8746 8746
=======================================
Hits 6880 6880
Misses 1866 1866 ☔ View full report in Codecov by Sentry. |
7ab89de
to
f55dd9c
Compare
f55dd9c
to
6ba82a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mbabker!
Could you please add an entry at CHANGELOG.md
for these deprecations?
…nnotation/attribute classes Co-authored-by: Javier Spagnoletti <phansys@gmail.com>
d5ac53b
to
d8701ed
Compare
Added |
Co-authored-by: Javier Spagnoletti <phansys@gmail.com>
Thank you @mbabker! |
When attributes support was added, the way slug handlers were configured was changed between annotations and attributes. With annotations support now fully deprecated, it doesn't make sense to continue supporting annotation-specific config paths, so this PR deprecates the annotation style slug handler configuration. Specifically, this will:
Slug
attribute's$handlers
property, slug handlers are now configured through property-level attributesSlugHandlerOption
class entirely, it is unused by the attribute driver in favor of providing the options as an associative array on theSlugHandler
attributeBelow example (taken right out of the docs) is the same configuration for a field using both annotations and attributes to give a visual reference.