Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an internal trait to allow cross-version compatibility for ORM SQL walkers #2805

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented May 28, 2024

Ref: #2708

Sibling PR to #2758 and #2804 but this time targeted at SQL walker classes.

@franmomu
Copy link
Collaborator

franmomu commented Jun 8, 2024

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 38.26087% with 71 lines in your changes missing coverage. Please review.

Project coverage is 78.37%. Comparing base (0632ab1) to head (018761a).
Report is 20 commits behind head on main.

Files Patch % Lines
src/Tool/ORM/Walker/orm-3.php 0.00% 44 Missing ⚠️
src/Tool/ORM/Walker/orm-2.php 50.00% 22 Missing ⚠️
...ranslatable/Query/TreeWalker/TranslationWalker.php 77.77% 4 Missing ⚠️
src/Tool/ORM/Walker/SqlWalkerCompat.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2805      +/-   ##
==========================================
- Coverage   78.75%   78.37%   -0.38%     
==========================================
  Files         163      166       +3     
  Lines        8593     8579      -14     
==========================================
- Hits         6767     6724      -43     
- Misses       1826     1855      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franmomu franmomu merged commit 1f3cb75 into doctrine-extensions:main Jun 9, 2024
26 of 34 checks passed
@franmomu
Copy link
Collaborator

franmomu commented Jun 9, 2024

thanks @mbabker!

@mbabker mbabker deleted the walker-compat branch June 9, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants