chore: add missing Vue support for Vercel builds#2134
Merged
sy-records merged 2 commits intodevelopfrom Jul 18, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6 tasks
Member
|
Hi @trusktr , That's what I work on the 2 One is We could have a compare on them easily. Maybe we should sync common files |
Koooooo-7
approved these changes
Jul 18, 2023
sy-records
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We currently have two
index.htmlfiles (why is that again?). One file was not loading Vue stuff.Without the Vue support in Vercel builds, we were unable to fully verify pull request builds, therefore unable to confirm if Vue broke or not. Now we can manually check Vue functionality for PRs.
What kind of change does this PR introduce?
Add Vue support to the index.html file that didn't have it.
For any code change,
Does this PR introduce a breaking change? (check one)
No
If yes, please describe the impact and migration path for existing applications:
Related issue, if any:
Tested in the following browsers: