Repository navigation
fix(datamodel): let the extension pick between OLE2 legacy Office formats - #4476
Merged
Merged
Conversation
…mats filetype reports an OLE2 file whose first sector is a FAT sector as Excel or PowerPoint, so a Word .doc was routed to the wrong backend. When the detected type is one of the OLE2 based formats (doc, ppt, xls), resolve it from the file extension instead. Resolves docling-project#4474 Signed-off-by: drakeo338 <paranoyouz@gmail.com>
Contributor
|
✅ DCO Check Passed Thanks @drakeo338, all your commits are properly signed off. 🎉 |
Contributor
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4474
A Word .doc whose first OLE2 sector is a FAT sector is detected by
filetypeas Excel or PowerPoint, so it was sent to the wrong backend and failed. When the detected type is one of the OLE2-based legacy formats (doc, ppt, xls), the format is now resolved from the file extension instead. A file with a misleading extension is still misrouted, which is the same trade-off the extension fallback already makes elsewhere.Checklist:
tests/test_input_doc.py: 13 passed on the committed HEAD; 3 of the new ones fail without the fix)make validatewas not run.