feat: add use_bundled_models flag to RapidOcrOptions (#2584) #2896
+29
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ DCO Check Passed Thanks @geoHeil, all your commits are properly signed off. 🎉 |
…#2584) Add explicit control for using RapidOCR's bundled models instead of artifacts_path. This addresses the issue where users couldn't use RapidOCR's pre-packaged models when artifacts_path was set globally. Changes: - Add use_bundled_models flag to RapidOcrOptions (default: False) - When True: Ignores artifacts_path and uses RapidOCR's bundled models - When False: Follows Docling's standard behavior (uses artifacts_path) - Explicitly set model paths always take precedence This maintains Docling's design philosophy where artifacts_path controls model sources by default, while providing an explicit opt-in for users who want to use RapidOCR's pre-installed models. Fixes docling-project#2584 Signed-off-by: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
geoHeil
force-pushed
the
fix/rapidocr-v2
branch
from
b70f196 to
d34d11a
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #2584 (comment)