fix(docx): Missing list items after numbered header #2665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
|
Related Documentation Checked 4 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Contributor
|
✅ DCO Check Passed Thanks @dolfim-ibm, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Remove 'current_parent is None' check in '_add_list_item' function since it will always be None. Signed-off-by: Cesar Berrospi Ramis <ceb@zurich.ibm.com>
cau-git
approved these changes
Nov 21, 2025
emreclsr
added a commit
to emreclsr/docling
that referenced
this pull request
Nov 25, 2025
…2665) This commit fixes an issue where list items immediately following headings (especially numbered headings) were not being processed correctly in Word documents. Changes: * Clear list history after headings to allow new lists to start * Reset level tracking when heading resets hierarchy * Reset level_at_new_list when a heading is added * Replace else block with explicit elif condition for new list sequences - Only continue existing list if parent is actually a ListGroup - Handle different numid or missing ListGroup parent by creating new list Added test case to verify list items appear after numbered headings. Signed-off-by: Emre Çalışır <emrecalisir95@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue resolved by this Pull Request:
Resolves #2250
Checklist: