Skip to content

Conversation

@dolfim-ibm
Copy link
Contributor

@dolfim-ibm dolfim-ibm commented Oct 20, 2025

Allow to process password-protected PDF documents.

Still TODO:

Refactor of backend options:

  • Extend backend_options to all document backends
  • Simplify logic as "if you set backend_options, you have to also set a backend which supports them"

Issue resolved by this Pull Request:
Resolves #1081

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@mergify
Copy link

mergify bot commented Oct 20, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

@dolfim-ibm dolfim-ibm changed the title add test and example for PDF with password feat(pdf): Support for password-protected PDF documents Oct 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025

DCO Check Passed

Thanks @dolfim-ibm, all your commits are properly signed off. 🎉

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
docling/cli/main.py 60.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
PeterStaar-IBM
PeterStaar-IBM previously approved these changes Oct 21, 2025
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@dolfim-ibm dolfim-ibm requested review from cau-git and ceberam October 21, 2025 15:02
@dolfim-ibm dolfim-ibm marked this pull request as ready for review October 21, 2025 15:02
@dosubot
Copy link

dosubot bot commented Oct 21, 2025

Documentation Updates

Checked 3 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Copy link
Contributor

@ceberam ceberam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall backend options look now very robust.

ceberam
ceberam previously approved these changes Oct 22, 2025
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@dolfim-ibm dolfim-ibm merged commit bbe82a6 into main Oct 22, 2025
25 checks passed
@dolfim-ibm dolfim-ibm deleted the feat-pdf-password branch October 22, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option for input password for reading locked PDF

5 participants