Repository navigation
test(client): stop using the deprecated DoclingServeApi.toBuilder() - #716
Merged
edeandrea merged 1 commit intoSep 30, 2026
Conversation
Copy APIs through config().toBuilder() in the client tests, and call toBuilder() on the concrete client type in the tests of the copy constructor, so no test depends on the deprecated method anymore. Part of docling-project#697 Signed-off-by: Eric Deandrea <eric.deandrea@ibm.com>
edeandrea
enabled auto-merge (squash)
September 30, 2026 15:39
:java_duke: JaCoCo coverage report
|
|
||||||||||||||
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
Contributor
|
🎉 This issue has been resolved in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DoclingServeApi.toBuilder()is deprecated for removal in favor ofconfig().toBuilder(). This removes the last usages of it, which were all in thedocling-serve-clienttests.DoclingServeJackson2ClientTests,DoclingServeJackson3ClientTestsandAbstractDoclingServeClientAsyncExecutorTestscopy the API throughconfig().toBuilder().AbstractDoclingServeClientConfigTeststests thetoBuilder()copy constructor of the clients, whichconfig().toBuilder()does not exercise (it goes through the provider and only keeps the options ofDoclingServeApiConfig). EachDoclingServeJackson{2,3}ClientConfigTestsnow implements acopyOfhook that callstoBuilder()on the concrete client type, which isn't deprecated. This also drops the@SuppressWarnings("removal")from those tests.The
toBuilder()declaration and its implementations are untouched, since removing them is a breaking change tracked in #697.Part of #697