Skip to content

Conversation

samiuc
Copy link
Contributor

@samiuc samiuc commented Oct 6, 2025

…limits

Signed-off-by: samiuc <sami.ullah.chat@gmail.com>
Copy link
Contributor

github-actions bot commented Oct 6, 2025

DCO Check Passed

Thanks @samiuc, all your commits are properly signed off. 🎉

Copy link

mergify bot commented Oct 6, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@samiuc samiuc requested a review from cau-git October 6, 2025 19:05
Copy link
Contributor

@cau-git cau-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samiuc This looks nice!Just one question: Do we need the max_workers thing?

samiuc added 2 commits October 7, 2025 18:25
Signed-off-by: samiuc <sami.ullah.chat@gmail.com>
Signed-off-by: samiuc <sami.ullah.chat@gmail.com>
@samiuc
Copy link
Contributor Author

samiuc commented Oct 8, 2025

This looks nice!Just one question: Do we need the max_workers thing?

Thanks! The max_workers parameter isn’t strictly required, it’s optional. It just helps control concurrency when multiple tests are running in parallel

Signed-off-by: samiuc <sami.ullah.chat@gmail.com>
@samiuc samiuc requested a review from cau-git October 8, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants