fix: forward missing kwargs from save_as_markdown to export_to_markdown#629
Closed
nohdonggyeong wants to merge 4 commits into
Closed
fix: forward missing kwargs from save_as_markdown to export_to_markdown#629nohdonggyeong wants to merge 4 commits into
nohdonggyeong wants to merge 4 commits into
Conversation
Add missing parameters to save_as_markdown that were present in export_to_markdown but not forwarded: - enable_chart_tables - mark_annotations - traverse_pictures - allowed_meta_names - blocked_meta_names
Contributor
|
❌ DCO Check Failed Hi @nohdonggyeong, your pull request has failed the Developer Certificate of Origin (DCO) check. This repository supports remediation commits, so you can fix this without rewriting history — but you must follow the required message format. 🛠 Quick Fix: Add a remediation commitRun this command: git commit --allow-empty -s -m "DCO Remediation Commit for nohdonggyeong <ehdrud1129@icloud.com>
I, nohdonggyeong <ehdrud1129@icloud.com>, hereby add my Signed-off-by to this commit: eee66996ef02d55eea8b624fdbfb2a2b78966800
I, nohdonggyeong <ehdrud1129@icloud.com>, hereby add my Signed-off-by to this commit: 66d5362c31db0ddd8d6a07092260cca28b3ead6a"
git push🔧 Advanced: Sign off each commit directlyFor the latest commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/main
git push --force-with-leaseMore info: DCO check report |
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesWaiting for
This rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
I, nohdonggyeong <ehdrud1129@icloud.com>, hereby add my Signed-off-by to this commit: eee6699 Signed-off-by: nohdonggyeong <ehdrud1129@icloud.com>
… save_as_markdown Signed-off-by: nohdonggyeong <ehdrud1129@icloud.com>
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
save_as_markdown()was missing five parameters that exist inexport_to_markdown()and were never forwarded to the internal call.
Fixes #619 (docling-project/docling)
Changes
Added the following parameters to
save_as_markdown()and forwarded them toexport_to_markdown():enable_chart_tables(default:True)mark_annotations(default:False)traverse_pictures(default:False)allowed_meta_names(default:None)blocked_meta_names(default:None)Also addressed the naming inconsistency:
escape_underscoresas the canonical parameter name (consistent withexport_to_markdown)escaping_underscoresas a deprecated alias with aDeprecationWarningfor backward compatibilityImpact Analysis
save_as_markdownis a wrapper that callsexport_to_markdowninternally.The added parameters are simply forwarded — no logic changes, no side effects.
All new parameters have safe defaults matching
export_to_markdownbehavior,so existing callers are unaffected.
For
escaping_underscores, the deprecated alias path only triggers whenexplicitly passed, so backward compatibility is preserved.
Verification
Tested all new parameters against the Docling technical report PDF:
All cases work as expected. Existing callers are unaffected.
Testing
Existing markdown tests pass.