fix: (continuation) Remove Extra Space Before and After Group Items#594
Closed
wanadzhar913 wants to merge 9 commits into
Closed
Conversation
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesWaiting for:
This rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Contributor
|
❌ DCO Check Failed Hi @wanadzhar913, your pull request has failed the Developer Certificate of Origin (DCO) check. This repository supports remediation commits, so you can fix this without rewriting history — but you must follow the required message format. 🛠 Quick Fix: Add a remediation commitRun this command: git commit --allow-empty -s -m "DCO Remediation Commit for Venkata Ramana Menda <mendavramana.jnv@gmail.com>
I, Venkata Ramana Menda <mendavramana.jnv@gmail.com>, hereby add my Signed-off-by to this commit: 0bc5d39a81dcc36b0c6480af99dffaefa0492af3"
git push🔧 Advanced: Sign off each commit directlyFor the latest commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/main
git push --force-with-leaseMore info: DCO check report |
…il.com> I, Venkata Ramana Menda <mendavramana.jnv@gmail.com>, hereby add my Signed-off-by to this commit: 00cda36 Signed-off-by: Venkata Ramana Menda <mendavramana.jnv@gmail.com>
Signed-off-by: wanadzhar913 <adzhar.faiq@gmail.com>
…il.com> I, Venkata Ramana Menda <mendavramana.jnv@gmail.com>, hereby add my Signed-off-by to this commit: 08049ee Signed-off-by: wanadzhar913 <adzhar.faiq@gmail.com>
…il.com> I, Venkata Ramana Menda <mendavramana.jnv@gmail.com>, hereby add my Signed-off-by to this commit: 08049ee Signed-off-by: wanadzhar913 <adzhar.faiq@gmail.com>
…il.com> I, Venkata Ramana Menda <mendavramana.jnv@gmail.com>, hereby add my Signed-off-by to this commit: 00cda36 Signed-off-by: Venkata Ramana Menda <mendavramana.jnv@gmail.com>
…il.com> I, Venkata Ramana Menda <mendavramana.jnv@gmail.com>, hereby add my Signed-off-by to this commit: 08049ee Signed-off-by: wanadzhar913 <adzhar.faiq@gmail.com>
…il.com> I, Venkata Ramana Menda <mendavramana.jnv@gmail.com>, hereby add my Signed-off-by to this commit: 08049ee Signed-off-by: wanadzhar913 <adzhar.faiq@gmail.com>
Whitespace already there? -> don't add any Can original source/provenance tell me? -> trust that Are both pieces text with styling differences? -> use heuristics Is one side code/formula/link? -> usually separate it from prose with a space Still unsure? -> default to no inserted space Signed-off-by: wanadzhar913 <adzhar.faiq@gmail.com>
5317b9f to
6dd1180
Compare
Contributor
Author
|
Closing due to DCO check failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This is a continuation of the work in Pull Request: #458
which emoves extra space before and after group items to resolve the issue raised in #2745
Resolves #371
Resolves docling-project/docling#2745
Approach
Refactors inline spacing in
docling_core/transforms/serializer/common.pyinto a clearer decision flow centered on_classify_inline_boundary()._join_inline_parts()is the entry point. It walks adjacent inline chunks, calls_classify_inline_boundary()for each boundary condition, and inserts a space only when that classifier returnsInlineBoundary.SPACE.