Skip to content

fix: path generation in case of relative file paths without artifact directory #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: path generation in case of relative file paths without artifact directory #363

wants to merge 2 commits into from
+15 −8

Conversation

geoHeil
Copy link

@geoHeil geoHeil commented Aug 7, 2025 •
edited by dolfim-ibm
Loading

Resolves #362

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025 •
edited
Loading

✅ DCO Check Passed

Thanks @geoHeil, all your commits are properly signed off. 🎉

@mergify Mergify
Copy link

mergify bot commented Aug 7, 2025 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@geoHeil geoHeil mentioned this pull request Aug 7, 2025
Open
@geoHeil geoHeil force-pushed the fix/get_output_paths-relative-no-artifactdir branch from 01cb61e to e92f120 Compare August 7, 2025 14:29
@geoHeil geoHeil changed the title fix path generation in case of relative file paths without artifact directory fix: path generation in case of relative file paths without artifact directory Aug 7, 2025
dolfim-ibm
dolfim-ibm requested changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@dolfim-ibm dolfim-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something weird here, it looks like you are duplicating the function _get_output_paths()?

@geoHeil
fix: path generation in case of relative file paths without artifact …
0bd7792 
…directory

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
@geoHeil geoHeil force-pushed the fix/get_output_paths-relative-no-artifactdir branch from e92f120 to 0bd7792 Compare August 7, 2025 14:32
@geoHeil
Copy link
Author

geoHeil commented Aug 7, 2025

There is something weird here, it looks like you are duplicating the function _get_output_paths()?

indeed - fix pushed now

@geoHeil
fix: clean text further
c41e9d5 
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolfim-ibm dolfim-ibm dolfim-ibm requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@geoHeil geoHeil

@dolfim-ibm dolfim-ibm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: relative asset path but no asset directory specified
2 participants
@geoHeil @dolfim-ibm