Skip to content

feat: add parameter to choose of which pages export the doctags #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

rickymaggio02
Copy link
Contributor

@rickymaggio02 rickymaggio02 commented May 12, 2025

Add parameter to export only certain pages to doctors from a Docling document

Signed-off-by: rickymaggio02 <riccardo.maggioni@googlemail.com>
Copy link

mergify bot commented May 12, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

Copy link
Collaborator

@vagenas vagenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickymaggio02

  • I have left some inline comments/suggestions.
  • Besides, let's test-cover the new param (you can draw inspiration from how we test minified in test_docling_doc.py).

@vagenas vagenas self-assigned this May 21, 2025
Signed-off-by: rickymaggio02 <riccardo.maggioni@googlemail.com>
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
docling_core/types/doc/document.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@vagenas vagenas merged commit 0fd3c1c into docling-project:main Jun 16, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants