feat: add parameter to choose of which pages export the doctags #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rickymaggio02 <riccardo.maggioni@googlemail.com>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
vagenas
requested changes
May 21, 2025
| @@ -3885,6 +3885,7 @@ def export_to_doctags( # noqa: C901 | |||
| add_table_cell_location: bool = False, | |||
| add_table_cell_text: bool = True, | |||
| minified: bool = False, | |||
| pages: Optional[list[int]] = None, | |||
There was a problem hiding this comment.
Let's make it a set since the underlying parameter is also a set.
Suggested change
| pages: Optional[list[int]] = None, | |
| pages: Optional[set[int]] = None, |
| @@ -3903,6 +3904,7 @@ def export_to_doctags( # noqa: C901 | |||
| :param # table specific flagsadd_table_cell_location: bool | |||
| :param add_table_cell_text: bool: (Default value = True) | |||
| :param minified: bool: (Default value = False) | |||
| :param pages: list[int]: (Default value = None) | |||
There was a problem hiding this comment.
Suggested change
| :param pages: list[int]: (Default value = None) | |
| :param pages: set[int]: (Default value = None) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parameter to export only certain pages to doctors from a Docling document