Skip to content

fix: HTMLTableSerializer efficiency and dir attribute #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ta0a2000t
Copy link

@ta0a2000t ta0a2000t commented May 3, 2025

HTMLTableSerializer Improvements

  • Changed indexing to iteration for the 2D linked list grid due to performance issues with large XLSX exports to Markdown. The original implementation was extremely slow and wouldn't finish. It is good now.
  • Also a tiny issue with text direction, and this PR fixes it.

fixes #279 (comment)

Copy link

mergify bot commented May 3, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@ta0a2000t ta0a2000t changed the title Improve HTMLTableSerializer efficiency and fix dir attribute fix HTMLTableSerializer efficiency and fix dir attribute May 3, 2025
@ta0a2000t ta0a2000t changed the title fix HTMLTableSerializer efficiency and fix dir attribute fix: HTMLTableSerializer efficiency and dir attribute May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

html serializer for table is too slow
1 participant