Skip to content

Comments

fix: Path to "Desktop" folder on Windows XP#1625

Merged
kroese merged 3 commits intodockur:masterfrom
AzimMuradov:fix-win-xp-desktop-path
Jan 13, 2026
Merged

fix: Path to "Desktop" folder on Windows XP#1625
kroese merged 3 commits intodockur:masterfrom
AzimMuradov:fix-win-xp-desktop-path

Conversation

@AzimMuradov
Copy link
Contributor Author

Currently successfully tested on Windows XP (EN), Windows XP (RU) and Windows 7 (EN).

Later going to test on Windows 7 (RU), several Windows Server images and Windows 11.

@kroese
Copy link
Contributor

kroese commented Jan 13, 2026

This .vbs script is only used for Windows 2000/XP/2003, not for Windows 7 and later. So is there any reason why you tested Win7?

@AzimMuradov
Copy link
Contributor Author

AzimMuradov commented Jan 13, 2026

This .vbs script is only used for Windows 2000/XP/2003, not for Windows 7 and later. So is there any reason why you tested Win7?

Huh, didn't see that 😅 You saved me couple of hours :)

Then I'm going to test only Windows Server 2003 (EN, RU), Windows 2000 (EN, RU).

Do I understand correctly that Windows Vista, Windows Server 2008 and later images use files from the assets directory (.xml) instead of generated .vbs?

@AzimMuradov
Copy link
Contributor Author

Then I'm going to test only Windows Server 2003 (EN, RU), Windows 2000 (EN, RU).

Successfully tested on Windows 2000 (EN), Windows 2000 (RU).

@kroese
Copy link
Contributor

kroese commented Jan 13, 2026

Do I understand correctly that Windows Vista, Windows Server 2008 and later images use files from the assets directory (.xml) instead of generated .vbs?

Yes.. Because XP/2003 do not support .xml installation, they use the .vbs method, but Vista and later do not need it.

@kroese kroese marked this pull request as ready for review January 13, 2026 12:41
@kroese kroese changed the title Fix path to "Desktop" folder to work correctly with different locales on Windows XP fix: Path to "Desktop" folder on Windows XP Jan 13, 2026
@kroese kroese merged commit 588969a into dockur:master Jan 13, 2026
2 checks passed
@AzimMuradov AzimMuradov deleted the fix-win-xp-desktop-path branch January 13, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Link to shared folder not created in Windows XP on non-English systems.

2 participants