remembering search items per page #2175 #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… consistent when navigating away and back to search page
coverbeck
requested changes
Apr 25, 2019
src/app/search/search-workflow-table/search-workflow-table.component.ts
Outdated
Show resolved
Hide resolved
src/app/search/search-tool-table/search-tool-table.component.ts
Outdated
Show resolved
Hide resolved
garyluu
approved these changes
Apr 25, 2019
src/app/search/search-workflow-table/search-workflow-table.component.ts
Outdated
Show resolved
Hide resolved
denis-yuen
reviewed
Apr 25, 2019
…ults table should stay consistent when navigating away and back to search page" This reverts commit b588248. # Conflicts: # cypress/integration/group2/searchTable.ts
denis-yuen
requested changes
Apr 25, 2019
coverbeck
approved these changes
Apr 25, 2019
| @@ -21,6 +21,11 @@ import { DockstoreService } from '../../shared/dockstore.service'; | |||
| import { Workflow } from '../../shared/swagger'; | |||
| import { SearchEntryTable } from '../search-entry-table'; | |||
| import { SearchQuery } from '../state/search.query'; | |||
| import {SearchService} from '../state/search.service'; | |||
There was a problem hiding this comment.
Ideally this would have the same format as the line above it.
| @@ -6,6 +6,11 @@ import { DockstoreService } from '../../shared/dockstore.service'; | |||
| import { DockstoreTool } from '../../shared/swagger'; | |||
| import { SearchEntryTable } from '../search-entry-table'; | |||
| import { SearchQuery } from '../state/search.query'; | |||
| import {SearchService} from '../state/search.service'; | |||
There was a problem hiding this comment.
Formatting same as previous line, ideally
denis-yuen
approved these changes
Apr 26, 2019
|
Pending passing build (not sure if real failure or not) |
agduncan94
approved these changes
Apr 26, 2019
Codecov Report
@@ Coverage Diff @@
## develop #634 +/- ##
===========================================
- Coverage 61.74% 61.74% -0.01%
===========================================
Files 238 238
Lines 7228 7241 +13
Branches 707 708 +1
===========================================
+ Hits 4463 4471 +8
- Misses 2592 2595 +3
- Partials 173 175 +2
Continue to review full report at Codecov.
|
@denis-yuen it looks like a flaky cypress test. Group 3 organizations.ts, the test is passing locally but failing on travis for some reason. Re-trying now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dockstore/dockstore#2175
Selected number of items per page in search results table should stay consistent when navigating away and back to search page. For example selecting 20 items per page then click navigating to an entry and then navigating back to the search page should continue to show 20 items per page rather than defaulting back to 10.