-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2216/active workflow clear #578
Merged
garyluu
merged 4 commits into
dockstore:develop
from
garyluu:feature/2216/activeWorkflowClear
Mar 14, 2019
Merged
Feature/2216/active workflow clear #578
garyluu
merged 4 commits into
dockstore:develop
from
garyluu:feature/2216/activeWorkflowClear
Mar 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #578 +/- ##
===========================================
- Coverage 61.76% 61.75% -0.02%
===========================================
Files 235 235
Lines 7101 7104 +3
Branches 694 693 -1
===========================================
+ Hits 4386 4387 +1
- Misses 2545 2547 +2
Partials 170 170
Continue to review full report at Codecov.
|
coverbeck
reviewed
Mar 13, 2019
Removed all the non-relevant formatting changes |
coverbeck
approved these changes
Mar 13, 2019
agduncan94
approved these changes
Mar 14, 2019
denis-yuen
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For dockstore/dockstore#2216
Hide whitespace changes when reviewing
Basically sets active workflow and tool to null upon workflow component and tool component init.
But because my-workflow and my-tool checks for tool or workflow, it must be moved down the chain to avoid expressionChangedAfterItHasBeenChecked.