Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2216/active workflow clear #578

Merged
merged 4 commits into from
Mar 14, 2019
Merged

Feature/2216/active workflow clear #578

merged 4 commits into from
Mar 14, 2019

Conversation

garyluu
Copy link
Contributor

@garyluu garyluu commented Mar 13, 2019

For dockstore/dockstore#2216

Hide whitespace changes when reviewing

Basically sets active workflow and tool to null upon workflow component and tool component init.

But because my-workflow and my-tool checks for tool or workflow, it must be moved down the chain to avoid expressionChangedAfterItHasBeenChecked.

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #578 into develop will decrease coverage by 0.01%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #578      +/-   ##
===========================================
- Coverage    61.76%   61.75%   -0.02%     
===========================================
  Files          235      235              
  Lines         7101     7104       +3     
  Branches       694      693       -1     
===========================================
+ Hits          4386     4387       +1     
- Misses        2545     2547       +2     
  Partials       170      170
Impacted Files Coverage Δ
src/app/workflow/tool-tab/tool-tab.component.ts 69.23% <0%> (ø) ⬆️
src/app/shared/state/workflow.service.ts 53.96% <66.66%> (-0.14%) ⬇️
src/app/shared/tool/tool.service.ts 69.56% <66.66%> (-3.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d85548a...1d71d02. Read the comment docs.

@garyluu
Copy link
Contributor Author

garyluu commented Mar 13, 2019

Removed all the non-relevant formatting changes

@garyluu garyluu requested a review from coverbeck March 13, 2019 21:21
@garyluu garyluu merged commit 79446ba into dockstore:develop Mar 14, 2019
@garyluu garyluu deleted the feature/2216/activeWorkflowClear branch March 14, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants