Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2180/nextflow dag buttons #573

Merged
merged 6 commits into from
Mar 13, 2019
Merged

Feature/2180/nextflow dag buttons #573

merged 6 commits into from
Mar 13, 2019

Conversation

garyluu
Copy link
Contributor

@garyluu garyluu commented Mar 12, 2019

For dockstore/dockstore#2180
which fixes the controls by putting them in its own div under the possible warnings
Also:

  • remove cwlviewer expand styles because the dag.component does the expanding now
  • gave WDL workflows the possible "DAG cannot be created because some required tools are missing from Github repo" alert
  • only show warning alerts if there actually is no dagResults
  • guard against no files in wdl-viewer (if the files endpoint errors out, it should not be in a continuous loading state)

@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #573 into develop will decrease coverage by 0.02%.
The diff coverage is 22.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #573      +/-   ##
===========================================
- Coverage    61.73%   61.71%   -0.03%     
===========================================
  Files          232      232              
  Lines         7067     7070       +3     
  Branches       693      693              
===========================================
  Hits          4363     4363              
- Misses        2534     2537       +3     
  Partials       170      170
Impacted Files Coverage Δ
...pp/workflow/dag/wdl-viewer/wdl-viewer.component.ts 53.44% <22.22%> (-2.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a97d2e6...cd0210d. Read the comment docs.

@garyluu garyluu merged commit ef85ecd into dockstore:develop Mar 13, 2019
@garyluu garyluu deleted the feature/2180/nextflowDAGButtons branch March 13, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants