Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/organization members #534

Merged
merged 15 commits into from
Jan 31, 2019
Merged

Feature/organization members #534

merged 15 commits into from
Jan 31, 2019

Conversation

garyluu
Copy link
Contributor

@garyluu garyluu commented Jan 29, 2019

Preliminary organization members CRUD

@garyluu garyluu force-pushed the feature/organizationMembers branch from edf9d34 to c225e13 Compare January 29, 2019 22:26
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #534 into develop will decrease coverage by 0.23%.
The diff coverage is 44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #534      +/-   ##
===========================================
- Coverage     62.4%   62.16%   -0.24%     
===========================================
  Files          218      221       +3     
  Lines         6556     6655      +99     
  Branches       652      661       +9     
===========================================
+ Hits          4091     4137      +46     
- Misses        2307     2360      +53     
  Partials       158      158
Impacted Files Coverage Δ
...ganizations/state/register-organization.service.ts 50.74% <ø> (ø) ⬆️
.../organizations/state/organization-members.store.ts 80% <ø> (ø) ⬆️
...izations/state/upsert-organization-member.store.ts 100% <100%> (ø)
...izations/state/upsert-organization-member.query.ts 100% <100%> (ø)
...rganizations/state/organization-members.service.ts 40.38% <30.76%> (-28.37%) ⬇️
.../organizations/state/organization-members.query.ts 62.5% <37.5%> (-23.22%) ⬇️
...ations/state/upsert-organization-member.service.ts 39.58% <39.58%> (ø)
...rc/app/organizations/state/organization.service.ts 45.65% <43.75%> (+4.91%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f92328...6c294e5. Read the comment docs.

*
* @param {OrganisationUser[]} organizationUsers The latest array of organization users
* @memberof OrganizationMembersService
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the method have the @transaction() annotation, given all the store interactions that are happening?

@garyluu garyluu merged commit 3d6c3c4 into develop Jan 31, 2019
@garyluu garyluu deleted the feature/organizationMembers branch January 31, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants