Feature/approve org requests

[agduncan94]

Adds a request tab to the accounts page, where:

• Admins can approve or reject organisations
• Users can see their pending organisations
• Users can accept or reject organisation invites

Currently needs a new release with dockstore/dockstore#2044

Top of page

Requests

[codecov]

Codecov Report

Merging #529 into develop will decrease coverage by 0.29%.
The diff coverage is 39.28%.

@@            Coverage Diff            @@
##           develop    #529     +/-   ##
=========================================
- Coverage    62.69%   62.4%   -0.3%     
=========================================
  Files          215     218      +3     
  Lines         6473    6556     +83     
  Branches       650     652      +2     
=========================================
+ Hits          4058    4091     +33     
- Misses        2259    2307     +48     
- Partials       156     158      +2

Impacted Files	Coverage Δ
src/app/shared/user/user.query.ts	64.28% <0%> (-10.72%)	⬇️
...ganizations/state/register-organization.service.ts	50.74% <0%> (ø)	⬆️
src/app/loginComponents/state/requests.service.ts	25.8% <25.8%> (ø)
src/app/loginComponents/state/requests.store.ts	85.71% <85.71%> (ø)
src/app/loginComponents/state/requests.query.ts	91.66% <91.66%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1337e7c...520dd11. Read the comment docs.

[coverbeck]

Screenshot feedback:

1. I suggest saying Decline instead of Reject for invitations.
2. I feel the Reject button is too jarring and prominent. I would be inclined to give it less emphasis per Material guidelines. On the other hand, maybe Reject should be just as prominent, as the default action won't necessarily be to approve. Not sure... It just doesn't look quite right to me.

[coverbeck]

If this is for accepting an invite, I think it should say you're accepting/declining the invitation, not the organization.

Also, if you were invited to more than one org, which is probably unlikely, it would be nice to know the org name you are accepting.

[coverbeck]

I think you should say reject here. :)

Sorry I wasn't clearer in my earlier suggestion -- I think you should decline invites, but I think you should reject organizations. Because rejecting an org is a bigger deal, I think it needs a stronger word.

[agduncan94]

Oops I'll change those back.

[coverbeck]

Suggest reject -- see previous comment; I won't flag any more if there are any